Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply a Trivy suggestion #627

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Apply a Trivy suggestion #627

merged 1 commit into from
Nov 18, 2024

Conversation

claudioandre-br
Copy link
Member

@claudioandre-br claudioandre-br commented Nov 18, 2024 •
edited
Loading

Describe your changes

From docs:

  • You should use COPY instead of ADD unless you want to extract a tar file. Note that an ADD command will extract a tar file, which adds the risk of Zip-based vulnerabilities. Accordingly, it is advised to use a COPY command, which does not extract tar files.

Checklist before requesting a review

  • I checked that all workflows return a success.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I followed the Conventional Commit spec.

Maintainer tasks

  • Label as either: bug, ci, docker, documentation, enhancement.
  • Sign unsigned commits.

@claudioandre-br claudioandre-br added the ci Continuous integration and/or continuous delivery label Nov 18, 2024
@claudioandre-br
security(cloud): apply a Trivy suggestion (#627)
b26cff5 
From docs:
- You should use COPY instead of ADD unless you want to extract a tar file.
  Note that an ADD command will extract a tar file, which adds the risk
  of Zip-based vulnerabilities. Accordingly, it is advised to use a COPY
  command, which does not extract tar files.

Signed-off-by: Claudio André <[email protected]>
@claudioandre-br claudioandre-br changed the title Apply a tryvi suggestion Apply a Trivy suggestion Nov 18, 2024
github-actions[bot]
github-actions bot approved these changes Nov 18, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved PR

@claudioandre-br
Copy link
Member Author

bot: MERGE trial

@claudioandre-br
Copy link
Member Author

bot: MERGE

@github-actions github-actions bot merged commit b26cff5 into openwall:main Nov 18, 2024
10 checks passed
@claudioandre-br
Copy link
Member Author

Everyone here is my witness:

  • merge from a fork and it worked!

@claudioandre-br claudioandre-br deleted the fix/security branch November 18, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
ci Continuous integration and/or continuous delivery
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@claudioandre-br