Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: fix(ci): use SSH on the merge bot #608

Merged
merged 1 commit into from
Nov 15, 2024
Merged

revert: fix(ci): use SSH on the merge bot #608

merged 1 commit into from
Nov 15, 2024

Conversation

claudioandre-br
Copy link
Member

@claudioandre-br claudioandre-br commented Nov 15, 2024

Describe your changes

This reverts commit 6579932.

A bot running from a PR fork has no access to secrets. Therefore, #607 is useless.

Merge-bot will only be used for merges originating from the upstream repository. It works in this scenario.

So I'm reverting #607, as it's neither useful nor necessary.

Checklist before requesting a review

  • I checked that all workflows return a success.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I followed the Conventional Commit spec.

Maintainer tasks

  • Label as either: bug, ci, docker, documentation, enhancement.
  • Sign unsigned commits.

This reverts commit 6579932.

A bot running from a PR fork has no access to secrets. Therefore, #607
is useless.

Merge-bot will only be used for merges originating from the upstream
repository. It works in this scenario.

So I'm reverting #607, as it's neither useful nor necessary.

Signed-off-by: Claudio André <[email protected]>
@claudioandre-br claudioandre-br added the ci Continuous integration and/or continuous delivery label Nov 15, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved PR

Copy link
Member Author

@claudioandre-br claudioandre-br left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bot: MERGE

@github-actions github-actions bot merged commit 3fd4dc6 into main Nov 15, 2024
18 checks passed
@claudioandre-br claudioandre-br deleted the revert branch November 15, 2024 19:54
@claudioandre-br claudioandre-br restored the revert branch November 15, 2024 19:59
@claudioandre-br claudioandre-br deleted the revert branch November 16, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration and/or continuous delivery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant