Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Coverity] GPU Plugin Medium issues #27761

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[Coverity] GPU Plugin Medium issues #27761

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa000dd
fix coverity issue
mhpanah Nov 26, 2024
80c6ff9
addressing feedback
mhpanah Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/plugins/intel_gpu/include/intel_gpu/primitives/resample.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ namespace cldnn {
struct resample : public primitive_base<resample> {
CLDNN_DECLARE_PRIMITIVE(resample)

resample() : primitive_base("", {}) {}
resample() : primitive_base("", {}), scales_port(0) {}

using InterpolateOp = ov::op::util::InterpolateBase;

Expand Down
2 changes: 1 addition & 1 deletion src/plugins/intel_gpu/src/graph/impls/onednn/convolution_onednn.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ struct convolution_onednn : typed_primitive_onednn_impl<convolution> {

private:
int _zero_point_mask;
dnnl::memory::data_type _wzp_data_type;
dnnl::memory::data_type _wzp_data_type = dnnl::memory::data_type::undef;

protected:
std::unique_ptr<primitive_impl> clone() const override {
Expand Down
10 changes: 10 additions & 0 deletions ...intel_gpu/src/kernel_selector/kernels/fully_connected/fully_connected_kernel_bf_tiled.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -757,6 +757,11 @@ void FullyConnected_bf_tiled::GetUpdateDispatchDataFunc(KernelData& kd) const {
const auto& prim_params = static_cast<const fully_connected_params&>(params);

size_t quantize_grp_size = get_dynamic_quantize_group_size(prim_params);
if (quantize_grp_size == 0) {
std::cerr << "Error: quantize_grp_size is zero." << std::endl;
return;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use exception or assert here


size_t output_batch = get_output_aligned_bf_size(prim_params, false).first;

// Get index of the added shape-agnostic kernel
Expand Down Expand Up @@ -941,6 +946,11 @@ KernelsData FullyConnected_bf_tiled::GetMultiKernelsData(const Params &params,

size_t quantize_grp_size = get_dynamic_quantize_group_size(fc_params);

if (quantize_grp_size == 0) {
std::cerr << "Error: quantize_grp_size is zero." << std::endl;
return KernelsData();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use exception or assert here

}

bool bProperInput = fc_params.inputs[0].GetLayout() == dl;
if (!bProperInput && !fc_params.inputs[0].PitchesDifferFromLogicalDims()) {
bProperInput = (dl == DataLayout::fb && fc_params.inputs[0].GetLayout() == DataLayout::fyxb) ||
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/intel_gpu/src/plugin/transformations/kv_cache_fusion.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ KVCacheFusionMatcher::KVCacheFusionMatcher() {
return false;

// TODO: Support conversion internally
if (concat_node->get_output_element_type(0) != past_node->get_output_element_type(0))
if (!concat_node || concat_node->get_output_element_type(0) != past_node->get_output_element_type(0))
return false;

auto variable = past_node->get_variable();
Expand Down
Loading