[GPU]: SearchSorted basic implementation. #27356
Open
+790
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment. Added more tests.
pkowalc1
changed the title
pkowalc1
changed the title
sshlyapn
reviewed
Nov 18, 2024
| #define CMP < | ||
| #endif | ||
|
|
||
| OUTPUT_TYPE binary_search_thread(const INPUT0_TYPE search_val, |
There was a problem hiding this comment.
Please use FUNC() and FUNC_CALL() wrappers for functions to guarantee unique function names
| attach_search_sorted_impl::attach_search_sorted_impl() { | ||
| #define ADD_TYPE(type) std::make_tuple(data_types::type, format::bfyx), std::make_tuple(data_types::type, format::bfzyx) | ||
|
|
||
| implementation_map<search_sorted>::add(impl_types::ocl, |
There was a problem hiding this comment.
nit: could you please align these definitions with other implementations? Something like:
auto types = {
data_types::f32,
...
};
auto formats = {
format::bfyx,
format::bfzyx
};
implementation_map<search_sorted>::add(impl_types::ocl, shape_types::any, search_sorted_impl::create, types, formats);
| validate_inputs_count(op, {2}); | ||
| auto inputs = p.GetInputInfo(op); | ||
| auto roi_align_prim = cldnn::search_sorted(layer_type_name_ID(op), inputs[0], inputs[1], op->get_right_mode()); | ||
| p.add_primitive(*op, roi_align_prim); |
There was a problem hiding this comment.
As you are using impl_param.desc->output_data_types[0].value_or(data_types::i64); for shape inference, output_data_types have to be specified during primitive creation:
Suggested change
| p.add_primitive(*op, roi_align_prim); | |
| p.add_primitive(*op, roi_align_prim); | |
| p.output_data_types = get_output_data_types(op); |
There was a problem hiding this comment.
Fixed, but if it "has to be specified", why did it work before?(unit tests, func tests)???
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added GPU reference Search Sorted implementation will unit and func tests. Kernel supports dynamic shapes.
Details:
Tickets: