Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Use gpg instead of apt-key add to add the GPG key to APT keyrings directory #26922

Merged
merged 5 commits into from
Nov 11, 2024
Merged

[DOCS] Use gpg instead of apt-key add to add the GPG key to APT keyrings directory #26922

merged 5 commits into from
Nov 11, 2024

Conversation

ytxmobile98
Copy link
Contributor

@ytxmobile98 ytxmobile98 commented Oct 7, 2024 •
edited
Loading

Details:

Since apt-key add is deprecated, I tried by myself to instead use the gpg command to add the GPG key to APT keyrings directory.

This is what I tried on my own: https://gist.github.com/ytxmobile98/b198a8ef4d2affd713780b16159a6618#file-install-md

Tickets:

  • ticket-id

@ytxmobile98 ytxmobile98 requested a review from a team as a code owner October 7, 2024 00:30
@ytxmobile98 ytxmobile98 requested review from akopytko and removed request for a team October 7, 2024 00:30
@github-actions github-actions bot added the category: docs OpenVINO documentation label Oct 7, 2024
@sys-openvino-ci sys-openvino-ci added the ExternalPR External contributor label Oct 7, 2024
@ilya-lavrenov
Copy link
Contributor

ilya-lavrenov commented Oct 7, 2024 •
edited
Loading

Could you please also change it here https://github.com/openvinotoolkit/openvino/blob/master/.github/workflows/job_debian_packages.yml#L53 ?
It will be validated by CI service and we can check whether the change is valid on wider range of OSes

Will it work on Ubuntu 20.04? It's minimal version supported by OpenVINO.

@ilya-lavrenov ilya-lavrenov added this to the 2024.5 milestone Oct 7, 2024
@ytxmobile98 ytxmobile98 requested a review from a team as a code owner October 7, 2024 11:47
@github-actions github-actions bot added category: CI OpenVINO public CI github_actions Pull requests that update GitHub Actions code labels Oct 7, 2024
@ytxmobile98
Copy link
Contributor Author

Could you please also change it here https://github.com/openvinotoolkit/openvino/blob/master/.github/workflows/job_debian_packages.yml#L53 ? It will be validated by CI service and we can check whether the change is valid on wider range of OSes

Will it work on Ubuntu 20.04? It's minimal version supported by OpenVINO.

@ilya-lavrenov Hi, I have updated the yml file.

@ytxmobile98
docs: Use gpg instead of apt-key add to add the GPG key to APT ke…
22214c3 
…yrings

Since `apt-key add` is deprecated, I tried by myself to instead use the `gpg` command to add the GPG key to APT keyrings directory.
@ilya-lavrenov
Copy link
Contributor

build_jenkins

@ytxmobile98
Copy link
Contributor Author

@ilya-lavrenov @artanokhov It came to my attention that the requirements_pytorch file uses optimum==1.22.0 which is the latest version as of now, but optimum-intel uses optimum of version 1.23.0.dev0. Should I do something to fix this problem at the moment, or can it be safely ignored?

@ilya-lavrenov
Copy link
Contributor

ilya-lavrenov commented Oct 8, 2024 •
edited
Loading

@ilya-lavrenov @artanokhov It came to my attention that the requirements_pytorch file uses optimum==1.22.0 which is the latest version as of now, but optimum-intel uses optimum of version 1.23.0.dev0. Should I do something to fix this problem at the moment, or can it be safely ignored?

PR with fix #26948 by @rkazants

@ilya-lavrenov
Copy link
Contributor

build_jenkins

@ilya-lavrenov ilya-lavrenov added this pull request to the merge queue Oct 29, 2024
@akladiev akladiev removed this pull request from the merge queue due to a manual request Oct 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR will be closed in a week because of 2 weeks of no activity.

@github-actions github-actions bot added the Stale label Nov 10, 2024
@ilya-lavrenov ilya-lavrenov merged commit b8743fc into openvinotoolkit:master Nov 11, 2024
25 checks passed
@ytxmobile98 ytxmobile98 deleted the patch-1 branch November 11, 2024 14:35
NishantPrabhuFujitsu pushed a commit to NishantPrabhuFujitsu/openvino that referenced this pull request Nov 26, 2024
@ytxmobile98 @ilya-lavrenov @NishantPrabhuFujitsu
[DOCS] Use gpg instead of apt-key add to add the GPG key to APT k…
f77795b 
…eyrings directory (openvinotoolkit#26922)

### Details:

Since `apt-key add` is deprecated, I tried by myself to instead use the
`gpg` command to add the GPG key to APT keyrings directory.

This is what I tried on my own:
<https://gist.github.com/ytxmobile98/b198a8ef4d2affd713780b16159a6618#file-install-md>

### Tickets:
 - *ticket-id*

Co-authored-by: Ilya Lavrenov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artanokhov artanokhov artanokhov approved these changes

@akopytko akopytko Awaiting requested review from akopytko akopytko is a code owner automatically assigned from openvinotoolkit/openvino-docs-maintainers

Assignees

@artanokhov artanokhov

Labels
category: CI OpenVINO public CI category: docs OpenVINO documentation ExternalPR External contributor github_actions Pull requests that update GitHub Actions code Stale
Projects
None yet
Milestone
2024.5
Development

Successfully merging this pull request may close these issues.
4 participants
@ytxmobile98 @ilya-lavrenov @artanokhov @sys-openvino-ci