Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PyOV] Branch import_model and export_model implementations based on the model size #26237

Draft
wants to merge 38 commits into
base: master
Choose a base branch
from
Draft

[PyOV] Branch import_model and export_model implementations based on the model size #26237

wants to merge 38 commits into from
+66 −7

Conversation

p-wysocki
Copy link
Contributor

@p-wysocki p-wysocki commented Aug 26, 2024 •
edited
Loading

Details:

  • Currently on hold due to changes needed to plugins' CompiledModel().export_model() overloads
  • Branch import_model and export_model functionalities based on the model size
    • models smaller than or equal to 2GB can be imported using std::stringstream
    • models bigger than 2GB have to be imported using std::fstream
    • the reason is that std::stringstream does not support streams bigger than 2GB
  • Add test case simulating 2GB model import
  • This PR is a followup to [PyOV] Replace std::stringstream with std::fstream in import_model #25724

Tickets:

@p-wysocki p-wysocki added this to the 2024.4 milestone Aug 26, 2024
@p-wysocki p-wysocki requested a review from a team as a code owner August 26, 2024 13:33
@github-actions github-actions bot added the category: Python API OpenVINO Python bindings label Aug 26, 2024
@akuporos akuporos added the priority: medium Medium priority label Aug 27, 2024
@p-wysocki p-wysocki changed the title [PyOV] Branch import_model implementation based on the model size [PyOV] Branch import_model and export_model implementations based on the model size Aug 28, 2024
@ilya-lavrenov ilya-lavrenov modified the milestones: 2024.4, 2024.5 Aug 29, 2024
@p-wysocki p-wysocki marked this pull request as draft September 6, 2024 10:29
@github-actions GitHub Actions
Copy link
Contributor

This PR will be closed in a week because of 2 weeks of no activity.

@github-actions github-actions bot added the Stale label Oct 17, 2024
@mlukasze mlukasze added no_stale Do not mark as stale and removed Stale labels Oct 17, 2024
@MirceaDan99 MirceaDan99 mentioned this pull request Nov 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akuporos akuporos akuporos approved these changes

@ilya-lavrenov ilya-lavrenov ilya-lavrenov approved these changes

@almilosz almilosz Awaiting requested review from almilosz

Assignees

@akuporos akuporos

Labels
category: Python API OpenVINO Python bindings do_not_merge do_not_review no_stale Do not mark as stale
Projects
None yet
Milestone
2024.5
Development

Successfully merging this pull request may close these issues.
4 participants
@p-wysocki @ilya-lavrenov @akuporos @mlukasze