[Release] Add symlink verification before opening file #3097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
NNCF Common
kshpv
reviewed
Nov 19, 2024
| @@ -71,6 +72,7 @@ def load_from_dir(dir_path: str) -> Tuple[Dict[str, Any], Dict[str, str]]: | |||
| continue # Skip the metadata file | |||
|
|
|||
| try: | |||
| fail_if_symlink(statistics_file) | |||
There was a problem hiding this comment.
Could you add a specific function, such as safe_open, and use it here and below?
There was a problem hiding this comment.
I've added a missed symlink check instead of the method since this is just a hotfix. A proper solution should be provided as part of the statistics caching implementation change (from pickle).
MaximProshin
approved these changes
Nov 19, 2024
This reverts commit c3f84de.
kshpv
approved these changes
Nov 19, 2024
KodiaqQ
added a commit
to KodiaqQ/nncf
that referenced
this pull request
Nov 19, 2024
…it#3097) ### Changes - As stated in the title. ### Reason for changes - Fix after openvinotoolkit#3017. ### Related tickets - 157068 ### Tests - test_examples/620/ - passed (cherry picked from commit 7510b4f)
Merged
KodiaqQ
added a commit
that referenced
this pull request
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Reason for changes
Related tickets
Tests