Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CVS-154710, CVS-154711, Implement LoadFileInfoReporter and installSignalHandlers #2769

Open
wants to merge 71 commits into
base: main
Choose a base branch
from
Open

CVS-154710, CVS-154711, Implement LoadFileInfoReporter and installSignalHandlers #2769

wants to merge 71 commits into from
+132 −1

Conversation

18582088138
Copy link
Collaborator

@18582088138 18582088138 commented Oct 29, 2024 •
edited
Loading

🛠 Summary

JIRA/Issue : CVS-154710 and CVS-154711

  • Implement LoudFileInfoReporter in modelmanager
  • Implement installSignalHandlers();

🧪 Checklist

TODO list

  • Unit tests added.
  • The documentation updated.
  • Change follows security best practices.
    ``

@atobiszei
Copy link
Collaborator

Looks fine - shouldn't main be the target branch @18582088138 ?

@18582088138 18582088138 changed the base branch from ovms_windows3 to main November 14, 2024 08:54
rasapala
rasapala approved these changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@rasapala rasapala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please update PR description that it also implements InstallSignalhandler.

@18582088138 18582088138 changed the title CVS-154710, Implement LoadFileInfoReporter in modelmanager CVS-154710, CVS-154711, Implement LoadFileInfoReporter and installSignalHandlers Nov 22, 2024
@18582088138
Copy link
Collaborator Author

The describe and PR title are change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rasapala rasapala rasapala approved these changes

@atobiszei atobiszei Awaiting requested review from atobiszei

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@18582088138 @atobiszei @rasapala