TOOLS: use separate cuda alloc in perftest #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samnordmann
approved these changes
Nov 8, 2023
Sergei-Lebedev
force-pushed
the
topic/pt_cuda_alloc
branch
2 times, most recently
from
13a3c51 to
b3f8e2a
Compare
It's not different for host mem type, but host memory is less sensitive to memory pools. Update PR with host and cuda managed memory |
bureddy
approved these changes
Dec 15, 2023
Sergei-Lebedev
force-pushed
the
topic/pt_cuda_alloc
branch
from
b3f8e2a to
054c1d7
Compare
B-a-S
pushed a commit
to B-a-S/ucc
that referenced
this pull request
Jan 4, 2024
* TOOLS: use separate cuda alloc in perftest * REVIEW: fix review comments
janjust
pushed a commit
to janjust/ucc
that referenced
this pull request
Jan 31, 2024
* TOOLS: use separate cuda alloc in perftest * REVIEW: fix review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add CUDA memory allocation function to ucc_perftest
Why ?
Result of perftest might be biased due to use of internal memory pool in UCC.