-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TL/MLX5/MCAST: adding ip over ib mcast helper functions as well as some of the environment variables #861
Conversation
e23dd95
to
0e09a78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me. I just left some minor comments
0e09a78
to
ffd47f9
Compare
@samnordmann thanks for the comments. I have updated the commit. |
ffd47f9
to
d8d3227
Compare
@samnordmann @Sergei-Lebedev Thank you guys for the helpful comments. I updated the commit and responded to the comments. Thank you. |
d8d3227
to
1d02f84
Compare
@Sergei-Lebedev @samnordmann thanks for the review. The commit is ready. |
@samnordmann I can print a warning if fclose() fail. It will not affect the mcast init if it fclose() fails. Furthermore, other parts of UCC also do not check the return value. I will update the commit. |
1d02f84
to
7fb7f36
Compare
@samnordmann I updated the commit. |
There could be an error also at file opening, and in this case it will affect the mcast init |
@samnordmann fopen() checks for error, if return is NULL, we are handling it |
7fb7f36
to
c43714c
Compare
@samnordmann I updated the commit, and I used the same return code as when we cannot open the file for fclose(). |
c43714c
to
7798823
Compare
7798823
to
6a88365
Compare
TL/MLX5: adding ip over ib mcast helper functions as well as some of the environment variables