TEST: fix one-sided tests always running #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
ok to test |
wfaderhold21
force-pushed
the
topic/fix_onesided_tests
branch
from
ff2bfc9 to
2147067
Compare
Sergei-Lebedev
approved these changes
Oct 2, 2023
samnordmann
approved these changes
Oct 5, 2023
Sergei-Lebedev
force-pushed
the
topic/fix_onesided_tests
branch
from
2147067 to
758d20a
Compare
nsarka
pushed a commit
to nsarka/ucc
that referenced
this pull request
Oct 24, 2023
* TEST: fix one-sided tests always running * TEST: sort list of collectives --------- Co-authored-by: ferrol aderholdt <[email protected]>
nsarka
pushed a commit
to nsarka/ucc
that referenced
this pull request
Oct 24, 2023
* TEST: fix one-sided tests always running * TEST: sort list of collectives --------- Co-authored-by: ferrol aderholdt <[email protected]>
janjust
pushed a commit
to janjust/ucc
that referenced
this pull request
Jan 31, 2024
* TEST: fix one-sided tests always running * TEST: sort list of collectives --------- Co-authored-by: ferrol aderholdt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Currently, when running mpi test, onesided tests will be performed regardless of the user specifically setting a non-onesided test to perform. For example,
mpirun -np 2 ucc_test_mpi -c allreduceWill perform both allreduce tests and onesided alltoall tests, which is not correct.