TL/MLX5: rcache and p2p lib for mcast

[MamziB]

TL/MLX5: adding rcache and a p2p library for mcast

@janjust

[samnordmann]

Hey @MamziB ! Thanks for the PR. I left some general comments.

Is it normal that the new files have not been added to the Makefile?
It would be a good thing to compile those files in order to spot compilation errors and also to make the Linter run on the files

[MamziB]

Hi @samnordmann Thank you so much for the helpful comments. I am planning to add these new files to Makerile.am as soon as all the dependencies are in place. Right now since this PR is dependent to many codes that are not included in this PR, we cannot compile it. In the next few PRs we will be able to compile these and run Linter over it.

[samnordmann]

Hi @samnordmann Thank you so much for the helpful comments. I am planning to add these new files to Makerile.am as soon as all the dependencies are in place. Right now since this PR is dependent to many codes that are not included in this PR, we cannot compile it. In the next few PRs we will be able to compile these and run Linter over it.

Hey Mamzi, ok, but can you briefly clarify though what this pr depends on?
It seemed to me that it does not depend so much on external code, except maybe some type declaration (e.g. ucc_tl_mlx5_mcast_coll_context_t ucc_tl_mlx5_mcast_p2p_completion_obj_t). Anyway, it would be useful for the review to have those declarations, and also it would allow to compile.

Am I missing other difficulties?

[MamziB]

@samnordmann Thanks for the note. Sure, let me resolve the dependencies and add a new commit.

[MamziB]

@Sergei-Lebedev @samnordmann Thank you all for your constructive comments. I appreciate it. Please kindly take a look at the new commit that has addressed your feedback.

[MamziB]

@Sergei-Lebedev Thanks for the second set of comments. Please take a look at the new commit. Thank you

[samnordmann]

Thanks @MamziB for the revisions. It looks good to me. I'm only leaving a couple of minor comments.
Can you please fix the Linter in github's checks ?

[MamziB]

@samnordmann @Sergei-Lebedev Hi Guys I have resolved/answered your feedback. I also converted all the commits into a single commit that can be merged into the master branch. Thanks again for your feedback.

[MamziB]

Thanks guys for the comments. @Sergei-Lebedev I have resolved your new comments and then I updated the commit itself.

[janjust]

@Sergei-Lebedev are all passing checks a requirement for mergers? I see some tests which failed in PRs already merged?
Thank you @Sergei-Lebedev and @samnordmann for detailed reviews. And a quick turnaround on the feedback.

[MamziB]

@Sergei-Lebedev Thanks sergei for the new comments. I appreciate it. I have updated the commit with the new changes.

[Sergei-Lebedev]

@Sergei-Lebedev are all passing checks a requirement for mergers? I see some tests which failed in PRs already merged? Thank you @Sergei-Lebedev and @samnordmann for detailed reviews. And a quick turnaround on the feedback.

Yes, all checks are required unless there is known issue