TL/SHARP: SHARP OOB fixes

- hide sharp lib errors - disable lazy init by default
openucx · Mar 9, 2023 · 0f1fd69 · 0f1fd69
1 parent 7b68768
commit 0f1fd69
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 1 deletion.
diff --git a/config/m4/sharp.m4 b/config/m4/sharp.m4
@@ -42,6 +42,8 @@ AS_IF([test "x$with_sharp" != "xno"],
             [
                 AC_SUBST(SHARP_CPPFLAGS, "-I$check_sharp_dir/include/ ")
                 AC_SUBST(SHARP_LDFLAGS, "-lsharp_coll -L$check_sharp_dir/lib")
+                AC_CHECK_DECLS([SHARP_COLL_HIDE_ERRORS], [], [], [[#include <sharp/api/sharp_coll.h>]])
+                AC_CHECK_DECLS([SHARP_COLL_DISABLE_LAZY_GROUP_RESOURCE_ALLOC], [], [], [[#include <sharp/api/sharp_coll.h>]])
             ],
             [
                 AS_IF([test "x$with_sharp" != "xguess"],

diff --git a/src/components/tl/sharp/tl_sharp.c b/src/components/tl/sharp/tl_sharp.c
@@ -30,7 +30,7 @@ static ucc_config_field_t ucc_tl_sharp_context_config_table[] = {
     {"", "", NULL, ucc_offsetof(ucc_tl_sharp_context_config_t, super),
      UCC_CONFIG_TYPE_TABLE(ucc_tl_context_config_table)},
 
-    {"DEVICES", "mlx5_0:1",
+    {"DEVICES", "",
      "SHARP device list",
      ucc_offsetof(ucc_tl_sharp_context_config_t, dev_list),
      UCC_CONFIG_TYPE_STRING},
@@ -55,6 +55,13 @@ static ucc_config_field_t ucc_tl_sharp_context_config_table[] = {
      ucc_offsetof(ucc_tl_sharp_context_config_t, context_per_team),
      UCC_CONFIG_TYPE_BOOL},
 
+#if HAVE_DECL_SHARP_COLL_DISABLE_LAZY_GROUP_RESOURCE_ALLOC
+    {"ENABLE_LAZY_GROUP_ALLOC", "n",
+     "Enable lazy group resource allocation",
+     ucc_offsetof(ucc_tl_sharp_context_config_t, enable_lazy_group_alloc),
+     UCC_CONFIG_TYPE_BOOL},
+#endif
+
     {"RAND_SEED", "0",
      "Seed for random sharp job ID. (0 - use default).",
      ucc_offsetof(ucc_tl_sharp_context_config_t, rand_seed),

diff --git a/src/components/tl/sharp/tl_sharp.h b/src/components/tl/sharp/tl_sharp.h
@@ -51,6 +51,7 @@ typedef struct ucc_tl_sharp_context_config {
     unsigned int             rand_seed;
     unsigned int             uprogress_num_polls;
     int                      context_per_team;
+    int                      enable_lazy_group_alloc;
 } ucc_tl_sharp_context_config_t;
 
 typedef struct ucc_tl_sharp_lib {

diff --git a/src/components/tl/sharp/tl_sharp_context.c b/src/components/tl/sharp/tl_sharp_context.c
@@ -300,6 +300,17 @@ ucc_status_t ucc_tl_sharp_context_init(ucc_tl_sharp_context_t *sharp_ctx,
     init_spec.config                         = sharp_coll_default_config;
     init_spec.config.user_progress_num_polls = sharp_ctx->cfg.uprogress_num_polls;
     init_spec.config.ib_dev_list             = sharp_ctx->cfg.dev_list;
+#if HAVE_DECL_SHARP_COLL_HIDE_ERRORS
+    if (lib->super.super.log_component.log_level < UCC_LOG_LEVEL_DEBUG) {
+        init_spec.config.flags               |= SHARP_COLL_HIDE_ERRORS;
+    }
+#endif
+#if HAVE_DECL_SHARP_COLL_DISABLE_LAZY_GROUP_RESOURCE_ALLOC
+    if(!sharp_ctx->cfg.enable_lazy_group_alloc) {
+        init_spec.config.flags               |= SHARP_COLL_DISABLE_LAZY_GROUP_RESOURCE_ALLOC;
+    }
+#endif
+
     init_spec.job_id                         = ((getpid() ^ pthread_self())
                                                 ^ rand_r(&sharp_ctx->cfg.rand_seed));
     init_spec.enable_thread_support          =