Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(itinerary-body): add and use showAlertEffectiveDateTimeText to alert components #799

Conversation

josh-willis-arcadis
Copy link
Contributor

Make the 'Effective as of [date]' line from the alert message configurable, as requested from the client.

Copy link
Contributor

@daniel-heppner-ibigroup daniel-heppner-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! just some style comments

packages/itinerary-body/src/TransitLegBody/alerts-body.tsx Outdated Show resolved Hide resolved
packages/itinerary-body/src/types.ts Outdated Show resolved Hide resolved
@josh-willis-arcadis josh-willis-arcadis changed the title feat(itinerary-body): add and use showAlertEffectiveDateTimeText to components feat(itinerary-body): add and use showAlertEffectiveDateTimeText to alert components Dec 5, 2024
Copy link
Contributor

@amy-corson-ibigroup amy-corson-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for including a story!!

@josh-willis-arcadis josh-willis-arcadis merged commit 1e50c60 into opentripplanner:master Dec 5, 2024
2 checks passed
@josh-willis-arcadis josh-willis-arcadis deleted the configure-and-style-alert-messaging branch December 5, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants