OTP2 route support in Transitive #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amy-corson-ibigroup
approved these changes
Nov 7, 2024
Comment on lines
407
to
410
| agency_id: leg.agencyId, | ||
| route_id: routeId, | ||
| route_short_name: routeLabel, | ||
| route_long_name: leg.route.longName || "", |
There was a problem hiding this comment.
These four are the same in both cases, can we extract these into their own constant and conditionally add the type, color, and text color?
There was a problem hiding this comment.
Yeah, I separated the common attributes in a022c74.
…eraryToTransitive.
daniel-heppner-ibigroup
approved these changes
Nov 12, 2024
daniel-heppner-ibigroup
assigned binh-dam-ibigroup and unassigned daniel-heppner-ibigroup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for OTP2 leg routes, so that route colors and names from OTP2-returned itineraries render correctly. A new mock is added to itinerary-body but that's only for Storybook for transitive-overlay (i.e. dev and test time), so no new package release for itinerary-body will be created.
I have removed map coordinates and zoom from transitive-overlay stories as these story parameters don't seem to affect rendering - the map is autofitted when a new itinerary is rendered.