Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(itinerary-body): indicate rented bikes in class name #790

Merged

Conversation

miles-grant-ibigroup
Copy link
Collaborator

Adds some class names that are helpful when styling

Copy link
Contributor

@daniel-heppner-ibigroup daniel-heppner-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These interpolated classnames kind of bug me. We end up with random spaces in the result too. I'll approve it to not hold you up but what do you think about adding a cn function to our utilities like this?
https://github.com/lukeed/clsx/blob/master/src/lite.js

@miles-grant-ibigroup
Copy link
Collaborator Author

These interpolated classnames kind of bug me. We end up with random spaces in the result too. I'll approve it to not hold you up but what do you think about adding a cn function to our utilities like this?
https://github.com/lukeed/clsx/blob/master/src/lite.js

I agree. Cleaner approach here would be to get the mode from OTP and then use that as the classname. Unfortunately there's a lot of ancient code that requires the class names as currently exist

@miles-grant-ibigroup miles-grant-ibigroup merged commit d76c17f into opentripplanner:master Nov 4, 2024
2 checks passed
@miles-grant-ibigroup miles-grant-ibigroup deleted the mark-bikeshare-legs branch November 4, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants