fix build issues by using alpha version #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -16,10 +16,10 @@ | |||
| "react-map-gl": "^7.0.15" | |||
| }, | |||
| "dependencies": { | |||
| "@opentripplanner/map-popup": "^4.0.0" | |||
| "@opentripplanner/map-popup": "^v3.2.0-alpha.1" | |||
There was a problem hiding this comment.
this is the fix
amy-corson-ibigroup
approved these changes
Sep 30, 2024
amy-corson-ibigroup
assigned daniel-heppner-ibigroup and unassigned amy-corson-ibigroup
|
So, it looks like Storybook was finding the .story files buried inside node modules. This was happening because of the copy all files flag we added to Babel to support the custom image in transitive overlay. I clamped down the glob used to find stories a bit by telling it to only look in the src directories of packages. Is this too restrictive? Let me know maybe we can adjust it. That image in the overlay keeps biting us |
daniel-heppner-ibigroup
assigned miles-grant-ibigroup and unassigned daniel-heppner-ibigroup
miles-grant-ibigroup
approved these changes
Oct 1, 2024
miles-grant-ibigroup
assigned daniel-heppner-ibigroup and unassigned miles-grant-ibigroup
daniel-heppner-ibigroup
merged commit 04e09ef
into
opentripplanner:master
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The master branch is completely messed up, so we need to use an alpha build to fix it. After this PR is merged we can eliminate the alpha dependency.
we don't need a semantic release fix commit because it will release based on previous commits already in master once the build succeeds.