Create Alert Component #744
Conversation
amy-corson-ibigroup
assigned daniel-heppner-ibigroup and unassigned miles-grant-ibigroup
| Icon?: any; | ||
| } | ||
|
|
||
| const AlertContainer = styled.div<{ |
There was a problem hiding this comment.
Should we consider going more semantic and using a details tag?
There was a problem hiding this comment.
Hmm I think this would actually make the component less customizable, since details always has a toggle, and this alert currently only has a toggle if collapsible is true
There was a problem hiding this comment.
is it possible to hide the toggle with CSS?
miles-grant-ibigroup
assigned amy-corson-ibigroup and unassigned daniel-heppner-ibigroup
| } | ||
| ]; | ||
|
|
||
| const alertKey = crypto.randomUUID(); |
There was a problem hiding this comment.
Why not just use i for the key? Does that break something?
There was a problem hiding this comment.
actually yeah this is bad because all the keys will all be the same!
There was a problem hiding this comment.
Good catch!! I moved this into the map so it actually does what it's supposed to do, although I guess i would work in this case because the order of the mock alerts in this story isn't going to change? Happy to change it if someone feels strongly?
There was a problem hiding this comment.
Actually I didn't realize this is just the story. It's fine, stories don't have to be perfect!
daniel-heppner-ibigroup
assigned amy-corson-ibigroup and unassigned daniel-heppner-ibigroup
amy-corson-ibigroup
assigned daniel-heppner-ibigroup and unassigned amy-corson-ibigroup
| } | ||
| ]; | ||
|
|
||
| const alertKey = crypto.randomUUID(); |
There was a problem hiding this comment.
Actually I didn't realize this is just the story. It's fine, stories don't have to be perfect!
daniel-heppner-ibigroup
assigned amy-corson-ibigroup and unassigned daniel-heppner-ibigroup
Creates a basic customizable alert in building blocks