Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align fare table content #661

Closed

Conversation

AdrianaCeric
Copy link
Member

A quick change to the alignment of the contents inside the table to allow for equal spacing between prices and the edge of the table cells.

To test:

  • Storybook --> TripDetails --> Leg Fare Products Itinerary
  • View on any configuration in otp-rr

Before
image
After
image

@daniel-heppner-ibigroup
Copy link
Contributor

I am not sure if this is something that should be made universal. I think I'd rather see this be configurable, since the original design choice was made intentionally to help people differentiate between the total and the per leg fares.

Do you think this is something we could override via stylesheet in the OTP-RR deployment where it's desired? Maybe we should just add some class names to the items we want to be able to override.

@AdrianaCeric
Copy link
Member Author

Closing this in favour of another config-specific ticket!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants