Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure driving directions #658

Merged
merged 7 commits into from
Oct 3, 2023
Merged

Configure driving directions #658

merged 7 commits into from
Oct 3, 2023

Conversation

amy-corson-ibigroup
Copy link
Contributor

@amy-corson-ibigroup amy-corson-ibigroup commented Sep 20, 2023 •
edited
Loading

Removes step-by-step driving directions from the itinerary body if hideDrivingDirections is enabled in the configuration.

binh-dam-ibigroup
binh-dam-ibigroup requested changes Sep 21, 2023
View reviewed changes
Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the changes would be much easier to read if separating the component and render logic when hiding driving directions vs. not (see comments).

packages/itinerary-body/package.json Outdated Show resolved Hide resolved
packages/itinerary-body/src/AccessLegBody/index.tsx Outdated Show resolved Hide resolved
packages/itinerary-body/src/AccessLegBody/index.tsx Show resolved Hide resolved
packages/itinerary-body/src/AccessLegBody/mapillary-button.tsx Outdated Show resolved Hide resolved
binh-dam-ibigroup
binh-dam-ibigroup requested changes Sep 22, 2023
View reviewed changes
Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you take care of some more cleanup, please.

packages/itinerary-body/src/AccessLegBody/index.tsx Outdated Show resolved Hide resolved
packages/itinerary-body/src/AccessLegBody/index.tsx Outdated Show resolved Hide resolved
packages/itinerary-body/src/AccessLegBody/index.tsx Outdated Show resolved Hide resolved
packages/itinerary-body/src/styled.tsx Outdated Show resolved Hide resolved
packages/itinerary-body/package.json Outdated Show resolved Hide resolved
binh-dam-ibigroup
binh-dam-ibigroup requested changes Sep 22, 2023
View reviewed changes
Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I should have requested the additional story before. See also the cleanup comment.

binh-dam-ibigroup
binh-dam-ibigroup approved these changes Sep 25, 2023
View reviewed changes
Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the changes!

@binh-dam-ibigroup
Copy link
Collaborator

@amy-corson-ibigroup Please remember to update the snapshots.

daniel-heppner-ibigroup
daniel-heppner-ibigroup approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@daniel-heppner-ibigroup daniel-heppner-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for adding the stories too!

packages/itinerary-body/src/AccessLegBody/index.tsx Show resolved Hide resolved
packages/itinerary-body/src/AccessLegBody/index.tsx Show resolved Hide resolved
@amy-corson-ibigroup amy-corson-ibigroup merged commit 6e6fc37 into opentripplanner:master Oct 3, 2023
@amy-corson-ibigroup amy-corson-ibigroup deleted the configure-driving-directions branch October 3, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdrianaCeric AdrianaCeric AdrianaCeric left review comments

@binh-dam-ibigroup binh-dam-ibigroup binh-dam-ibigroup approved these changes

@daniel-heppner-ibigroup daniel-heppner-ibigroup daniel-heppner-ibigroup approved these changes

Assignees

@amy-corson-ibigroup amy-corson-ibigroup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amy-corson-ibigroup @binh-dam-ibigroup @AdrianaCeric @daniel-heppner-ibigroup