Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(actions/ui): Hide nearby stops outside Stop Viewer. #998

Merged
merged 3 commits into from
Sep 19, 2023

Conversation

binh-dam-ibigroup
Copy link
Collaborator

Description

With this PR, nearby stops are hidden from the map when the stop viewer is not shown.

PR Checklist

  • [na] Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • [na] Are all languages supported (Internationalization/Localization)?
  • [na] Are appropriate Typescript types implemented?

Copy link
Collaborator

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch thanks!

Copy link
Member

@AdrianaCeric AdrianaCeric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good implementation!

@binh-dam-ibigroup binh-dam-ibigroup merged commit 82d12b7 into dev Sep 19, 2023
6 checks passed
@binh-dam-ibigroup binh-dam-ibigroup deleted the hide-nearbys-outside-stop-viewer branch September 19, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants