Alert if user clicks Plan Trip with invalid mode selection #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…P query will be issued.
amy-corson-ibigroup
approved these changes
Sep 13, 2023
lib/actions/api-constants.ts
Outdated
| @@ -0,0 +1,5 @@ | |||
| export const RoutingQueryResult = { | |||
There was a problem hiding this comment.
Would it be appropriate to rename to ROUTING_QUERY_RESULT? Even just to make it a bit more distinct from routingQueryResult in batch-settings.tsx
There was a problem hiding this comment.
Instead of changing the case, I picked a (better) name in 8a0e6c9.
i18n/en-US.yml
Outdated
| @@ -227,6 +227,7 @@ components: | |||
| modeSelectorLabel: Select a transit mode | |||
| BatchSettings: | |||
| destination: destination | |||
| invalidModeSelection: Cannot plan a trip using the selected modes. | |||
There was a problem hiding this comment.
Could we add another sentence like "Try including transit in your mode selection" just to point people in the right direction?
There was a problem hiding this comment.
Good idea! Added in c72cbc7.
AdrianaCeric
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an alert shown when user clicks "Plan Trip" with invalid modes selected (e.g. "car" alone).
No new alerts are shown when planning is triggered outside of clicking the "Plan Trip" button.
PR Checklist