refactor: avoid un-needed time chop-off #982
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just came across this one. Could setting the time-column component to have |
|
Possibly! I know there are a lot of nesting styles going on here and then quite a bit of a11y changes happened as well so I'll have to spend some proper time with it to double check that doesn't introduce any regressions |
|
I found that removing the width also did the trick. I think this is a lazy hack, but I've yet to find something else. Will look into it more, but let me know if you have any comments/suggestions! |
binh-dam-ibigroup
approved these changes
Sep 25, 2023
miles-grant-ibigroup
assigned daniel-heppner-ibigroup and unassigned miles-grant-ibigroup
|
Removing styles is always a good thing! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Itinerary body was sometimes breaking time text when it shouldn't be. This PR resolves this. Will leave PR open for now to collect other styling regressions.
PR Checklist: