Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle diet #1323

Merged
merged 5 commits into from
Dec 18, 2024
Merged

Bundle diet #1323

merged 5 commits into from
Dec 18, 2024

Conversation

binh-dam-ibigroup
Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup commented Dec 13, 2024

Description

This PR reduces bundle size with an OTP-UI itinerary-body package that doesn't require the full fa-solid library.
After deduplication, production bundle size should be ~8.5MB (~1MB zipped), down from ~12MB.

PR Checklist

  • Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • Are all languages supported (Internationalization/Localization)?
  • Are appropriate Typescript types implemented?

Before | After screenshot:

before and after screenshot of bundle analyzer results

Copy link
Contributor

@daniel-heppner-ibigroup daniel-heppner-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent

Copy link
Contributor

@josh-willis-arcadis josh-willis-arcadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@binh-dam-ibigroup binh-dam-ibigroup merged commit e7c513c into dev Dec 18, 2024
9 checks passed
@binh-dam-ibigroup binh-dam-ibigroup deleted the reduce-bundle branch December 18, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants