Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correctly make use of scoped vehicle ids #1317

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

miles-grant-ibigroup
Copy link
Collaborator

@miles-grant-ibigroup miles-grant-ibigroup commented Dec 5, 2024

Our behavior wasn't working because OTP vehicleId is now scoped. This adds support for a scoped vehicleId and therefore restores the correct behavior of the transit vehicle overlay.

Copy link
Contributor

@daniel-heppner-ibigroup daniel-heppner-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@josh-willis-arcadis josh-willis-arcadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@miles-grant-ibigroup miles-grant-ibigroup merged commit 7ea6e15 into dev Dec 13, 2024
9 checks passed
@miles-grant-ibigroup miles-grant-ibigroup deleted the correct-rt-bubble-behavior branch December 13, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants