Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auto-set sort direction on sort type change #1315

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

auto-set sort direction on sort type change #1315

wants to merge 2 commits into from

Conversation

miles-grant-ibigroup
Copy link
Collaborator

Sets ASC/DESC automatically on changing the sort type.

Do we want this behavior like this by default? Curious for opinions

amy-corson-ibigroup
amy-corson-ibigroup requested changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@amy-corson-ibigroup amy-corson-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a new search, when I set d/t to "depart" I'm consistently getting this blank dropdown
image

@miles-grant-ibigroup miles-grant-ibigroup added the BLOCKED Blocked (waiting on another PR to be merged) label Dec 13, 2024
@miles-grant-ibigroup
Copy link
Collaborator Author

Blocked by #1316

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amy-corson-ibigroup amy-corson-ibigroup amy-corson-ibigroup requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@miles-grant-ibigroup miles-grant-ibigroup

Labels
BLOCKED Blocked (waiting on another PR to be merged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miles-grant-ibigroup @amy-corson-ibigroup