Only call stopTimes if we don't already have the data #1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miles-grant-ibigroup
approved these changes
Nov 25, 2024
lib/actions/apiV2.js
Outdated
Comment on lines
509
to
514
| if ( | ||
| !params.forceFetch && | ||
| getState().otp.transitIndex.stops[params.stopId] | ||
| ) { | ||
| return | ||
| } |
There was a problem hiding this comment.
Can we one-line this if eslint lets us? Getting rid of the brackets might help.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes a bug where interaction with
setViewedRoutewas causing thefindStopTimesForStopand subsequent response to fire forever. This should only fire when the stop information isn't already there. Also adds aforceFetchparam for the stop schedule viewer, so that if you're trying to look at different schedule days, it will update the info with the new day.PR Checklist: