Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support naming and keying transit vehicle overlay #1297

Merged
merged 6 commits into from
Nov 25, 2024
Merged

Support naming and keying transit vehicle overlay #1297

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2128ad7
support naming and keying transit vehicle overlay
miles-grant-ibigroup Oct 30, 2024
1928b3e
Merge branch 'dev' into route-vehicles-overlay-name-override
miles-grant-ibigroup Nov 13, 2024
6cc7aba
address pr feedback
miles-grant-ibigroup Nov 13, 2024
ca26080
Merge branch 'dev' into route-vehicles-overlay-name-override
amy-corson-ibigroup Nov 21, 2024
0158db2
Merge branch 'dev' into route-vehicles-overlay-name-override
miles-grant-ibigroup Nov 22, 2024
0a062eb
fix bug causing percy crash
daniel-heppner-ibigroup Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion lib/components/map/default-map.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,10 @@ class DefaultMap extends Component {
const baseLayerUrls = baseLayersWithNames?.map((bl) => bl.url)
const baseLayerNames = baseLayersWithNames?.map((bl) => bl.name)

const routeBasedTransitVehicleOverlayNameOverride = overlays.find(
(o) => o.type === 'vehicles-one-route'
)?.name

return (
<MapContainer className="percy-hide">
<BaseMap
Expand All @@ -341,7 +345,13 @@ class DefaultMap extends Component {
{/* The default overlays */}
<EndpointsOverlay />
<RouteViewerOverlay />
<TransitVehicleOverlay ModeIcon={ModeIcon} />
<TransitVehicleOverlay
id={routeBasedTransitVehicleOverlayNameOverride || undefined}
miles-grant-ibigroup marked this conversation as resolved.
Show resolved Hide resolved
key={routeBasedTransitVehicleOverlayNameOverride || undefined}
ModeIcon={ModeIcon}
name={routeBasedTransitVehicleOverlayNameOverride || undefined}
visible
/>
<GeolocateControl
onGeolocate={() => {
getCurrentPosition(intl)
Expand Down
Loading