Enable https://github.com/opentripplanner/otp-react-redux/pull/1266 in call taker #1295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-heppner-ibigroup
requested changes
Oct 26, 2024
|
|
||
| if ( | ||
| syncSortWithDepartArrive && | ||
| DepartArriveTypeMap[departArrive as DepartArriveValue] !== sort.type |
There was a problem hiding this comment.
cast departArrive wherever you get it from
There was a problem hiding this comment.
It's a useState. TS doesn't like me typing it at definition time
daniel-heppner-ibigroup
assigned miles-grant-ibigroup and unassigned daniel-heppner-ibigroup
|
@daniel-heppner-ibigroup Typescript is giving me some trouble |
miles-grant-ibigroup
assigned daniel-heppner-ibigroup and unassigned miles-grant-ibigroup
daniel-heppner-ibigroup
force-pushed
the
sync-departarrive-on-calltaker
branch
from
ff9ce9e to
ac2e274
Compare
daniel-heppner-ibigroup
assigned miles-grant-ibigroup and unassigned daniel-heppner-ibigroup
daniel-heppner-ibigroup
approved these changes
Nov 18, 2024
|
Much cleaner thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Enables
syncSortWithDepartArriveto work in call taker. Mostly the same codePR Checklist: