Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(companions-pane): Add new companions pane to saved trip editor and account settings screen #1289
feat(companions-pane): Add new companions pane to saved trip editor and account settings screen #1289
Changes from 28 commits
ec66a9b
1fc76aa
122428b
c8ee71a
f41b91a
2f9b299
d186fc9
cf1c9b1
be648df
b5a7c25
8b3d4ab
ac4c41f
32d87f9
7496183
d07b51f
600fd50
7349731
b7ef0af
186b634
6b2da61
0f57130
ba97b8e
f039959
6599af5
3732363
a032296
a0fa2c7
c741d54
f07d9bc
f937cbd
574dc91
55a49fa
532800a
af90e01
5fbf59d
7c80158
994d9f8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is an interesting feature that was in the mockup, although I'm split on whether to have it for this pane. I'll let the other reviewer weigh in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not the biggest fan of it here. I think this is a nice to have feature, but it doesn't make sense if this is the only section that uses it. If all the sections were collapsable I think this would make more sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed