Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skeletonize Operator Logo Loading #1277

Conversation

miles-grant-ibigroup
Copy link
Collaborator

Description:
Uses Skeleton instead of InlineLoading which results in a less abrupt flash.

Thoughts? @amy-corson-ibigroup

Copy link
Contributor

@amy-corson-ibigroup amy-corson-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner! Can we add a height too so it's square? But yes I love this

@amy-corson-ibigroup amy-corson-ibigroup removed their assignment Sep 17, 2024
@miles-grant-ibigroup miles-grant-ibigroup merged commit 472abe8 into pass-operator-logos-to-map-popup Sep 18, 2024
4 of 5 checks passed
@miles-grant-ibigroup miles-grant-ibigroup deleted the pass-operator-logos-to-map-poup-skeletonized branch September 18, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants