-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trip Preview #1272
Trip Preview #1272
Conversation
Is this ready for review? |
@miles-grant-ibigroup Here is what aligning the "preview" link to the route numbers would look like... |
I am not going to implement it because (i) the multiple vertical alignments look untidy and (ii) the preview link may missed if many transit symbols are rendered. |
@daniel-heppner-ibigroup This is ready for review! |
I have a vision of like a looking glass before the icons but it's good enough for now. This thing isn't on by default is it? |
It will be available to all deployments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! only style comments so approving.
mapVisible?: boolean | ||
} | ||
|
||
class TripPreviewLayoutBase extends Component<Props, State> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was the reason behind going for a class component here rather than a function component?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy/paste is the reason...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks and works great! One small question but nothing blocking
Description
This PR adds a preview link to saved trips that opens a view similar to the print view, with just the map and the steps to take the trip.
Behind the scenes, a new
SimpleMap
component is extracted, without the user interactions, to which we can pass anitinerary
for display in the trip preview (and later in the print view too).PR Checklist
Saved Trip List with preview (map icon) link:
Trip Preview: