Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to use arrival time in nearby view #1269

Merged
merged 4 commits into from
Sep 19, 2024

Conversation

daniel-heppner-ibigroup
Copy link
Contributor

Description:
Adds configuration option to use the arrival time rather than departure time in Nearby View and other places where the patternrow is used.

Copy link
Collaborator

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will leave it up to the second reviewer to decide if that ternary is alright

lib/util/viewer.js Outdated Show resolved Hide resolved
Copy link
Contributor

@amy-corson-ibigroup amy-corson-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful new config item sorry for long delay in reviewing

lib/util/viewer.js Outdated Show resolved Hide resolved
@daniel-heppner-ibigroup daniel-heppner-ibigroup merged commit 4d2e68a into dev Sep 19, 2024
9 checks passed
@daniel-heppner-ibigroup daniel-heppner-ibigroup deleted the nearby-arrival-time branch September 19, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants