fix(nearby-view): Avoid blank nearby view on mobile #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-heppner-ibigroup
approved these changes
Sep 5, 2024
daniel-heppner-ibigroup
assigned amy-corson-ibigroup and unassigned daniel-heppner-ibigroup
|
Nope! The map |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes a bug where, on mobile when user had denied geolocation, a blank page was being displayed due to lack of coordinates. This was happening because the desktop fallback (using the map center as the nearby point) required rendering a map, and mobile does not. Instead, now we pass the
initLonandinitLatfrom the config.PR Checklist: