Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nearby View Cleanup Aug 2024 #1262

Merged
merged 4 commits into from
Sep 16, 2024
Merged

Conversation

miles-grant-ibigroup
Copy link
Collaborator

@miles-grant-ibigroup miles-grant-ibigroup commented Aug 26, 2024

Description:

  • add missing fields to graphql request that were in previous rest request. This allows the route headsign to be displayed if it is present

@miles-grant-ibigroup miles-grant-ibigroup self-assigned this Aug 26, 2024
@miles-grant-ibigroup miles-grant-ibigroup marked this pull request as draft August 26, 2024 15:26
@miles-grant-ibigroup miles-grant-ibigroup marked this pull request as ready for review September 6, 2024 17:32
Copy link
Contributor

@amy-corson-ibigroup amy-corson-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't argue with that!

@binh-dam-ibigroup
Copy link
Collaborator

* fix graphql

@miles-grant-ibigroup Could you put in the PR description what is the desired effect of the fix, please?

@miles-grant-ibigroup
Copy link
Collaborator Author

* fix graphql

@miles-grant-ibigroup Could you put in the PR description what is the desired effect of the fix, please?

Sorry! I expected there to be more fixes

@miles-grant-ibigroup miles-grant-ibigroup merged commit a0aa5af into dev Sep 16, 2024
9 checks passed
@miles-grant-ibigroup miles-grant-ibigroup deleted the nearby-view-cleanup-aug-2024 branch September 16, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants