fix(wizard): AT reads correct step number in account setup #1257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@josh-willis-arcadis @binh-dam-ibigroup if this is looking okay after Josh reviews, if you guys wouldn't mind merging while I'm out next week, that would be amazing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes a bug with Safari + Voiceover that was causing Voiceover to inconsistently read the incorrect step or title name when the step was changed. Eg. The user would be on step 3 of 4 but VO would announce it as step 2 of 4.
My best guess based on this thread is that safari was firing its nameChange/DescriptionChange event after passing the information to the screenreader in some cases. Putting
focusHeaderinsideComponentDidUpdateshould hopefully consistently focus the header after the browser has fully fired all events.PR Checklist: