Field trip august 2024 fixes #1256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-heppner-ibigroup
approved these changes
Aug 26, 2024
josh-willis-arcadis
approved these changes
Aug 30, 2024
| @@ -153,10 +153,12 @@ class CallTakerPanel extends Component { | |||
| } | |||
| } | |||
|
|
|||
| // eslint-disable-next-line complexity | |||
There was a problem hiding this comment.
I've seen this warning in other places. Should be disable those as well?
There was a problem hiding this comment.
No! It's a good reminder to make our code better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related to the plan functionality. The plan button was causing confusion and problems so we got rid of it when field trip is open. Then we had the problem that the location changes were getting wiped away. We solved this by adding a confirm before the locations are overriden. The issue with this approach is that we will not save the updated location to the trip. Maybe that's ok?