fix(saved-trip-editor): Route back button to saved trips if editing #1255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/components/user/back-link.js
Outdated
| @@ -12,14 +12,18 @@ const StyledButton = styled(Button)` | |||
| padding: 0; | |||
| ` | |||
|
|
|||
| export const backButtonContent = ( | |||
There was a problem hiding this comment.
Maybe this should be a component.
There was a problem hiding this comment.
Good call! Fixed in 127475c
| {/* If creating, back button should return to trip planner. If not, it should return | ||
| to saved trips, just in case the user accessed this page through their email. */} | ||
| {isCreating ? ( | ||
| <BackLink /> |
There was a problem hiding this comment.
If we are doing links, how about we place a <Link to="/"> for when isCreating is true? (The link will preserve query params in the URL)
There was a problem hiding this comment.
I think you're right, added in da8783a
|
@miles-grant-ibigroup @binh-dam-ibigroup if this is looking okay after Miles reviews, and you guys wouldn't mind merging while I'm out next week, that would be amazing! |
miles-grant-ibigroup
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes a bug where, if a user accessed the "edit trip" page through a link in their email, the "back" button would send them to a broken Auth0 url.
Now if a user is editing a trip, it will always take you back to saved trips.
PR Checklist: