Support GraphQL Trip Requests #1253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amy-corson-ibigroup
approved these changes
Aug 12, 2024
lib/actions/user.js
Outdated
Comment on lines
172
to
188
| function areRequestsSame(qp1, qp2) { | ||
| // Everything except modes. | ||
| // Exclude banned/preferred/unpreferred at this time. | ||
| return ( | ||
| qp1.bikeReluctance === qp2.bikeReluctance && | ||
| qp1.carReluctance === qp2.carReluctance && | ||
| qp1.date === qp2.date && | ||
| qp1.departArrive === qp2.departArrive && | ||
| qp1.from?.name === qp2.from?.name && | ||
| qp1.departArrive === qp2.departArrive && | ||
| qp1.time === qp2.time && | ||
| qp1.to?.name === qp2.to?.name && | ||
| qp1.walkReluctance === qp2.walkReluctance && | ||
| qp1.walkSpeed === qp2.walkSpeed && | ||
| qp1.wheelchair === qp2.wheelchair | ||
| ) | ||
| } |
There was a problem hiding this comment.
Instead of doing this many checks, would it be possible to filter out the properties you don't want to compare (eg. modes and banned routes) and then compare using JSON.stringify?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for parsing trip request data from OTP-middleware that includes GraphQL variables, so that they are included in the Recent Searches list.
Support for old OTP1 query params in trip requests from OTP-middleware is removed.
Note that the label for a recent search includes the modes used, however the modes will not be updated upon clicking the recent search entry (the mode selector states are not passed or saved in the trip request).
PR Checklist