Support chinese traditional #1245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently translated at 99.2% (541 of 545 strings) Translation: OTP-react-redux/OTP-RR Main UI Translate-URL: https://hosted.weblate.org/projects/otp-react-redux/otp-rr-main-ui/es/
Currently translated at 93.3% (509 of 545 strings) Translation: OTP-react-redux/OTP-RR Main UI Translate-URL: https://hosted.weblate.org/projects/otp-react-redux/otp-rr-main-ui/zh_Hant/
Currently translated at 93.3% (509 of 545 strings) Translation: OTP-react-redux/OTP-RR Main UI Translate-URL: https://hosted.weblate.org/projects/otp-react-redux/otp-rr-main-ui/zh_Hant/
…), Simplified as either zh or z
| // (The lang is the first portion of the locale.) | ||
| const lang = matchedLocale.split('-')[0] | ||
| document.documentElement.lang = lang | ||
| document.documentElement.lang = matchedLocale |
There was a problem hiding this comment.
The HTML lang tag can be a locale (language-suffix format) so we should be good here. See for instance https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/lang.
binh-dam-ibigroup
requested review from
amy-corson-ibigroup and
josh-willis-arcadis
amy-corson-ibigroup
approved these changes
Jul 8, 2024
amy-corson-ibigroup
removed
the
BLOCKED
Thanks for updating the OTP-UI packages! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Requires opentripplanner/otp-ui#741.
This PR adds support for Chinese Traditional (
zh-Hantin config,zh_Hant.ymlfor the content), including translated content from #1243 and code changes needed to enable that language. The Chinese (Simplified) file is renamed tozh_Hans.yml.Config changes:
zhis still supported by itself, i.e. if no other Chinese languages are configured such as Chinese (Traditional).zh-Hans.PR Checklist