Create Global Trip settings and variables #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amy-corson-ibigroup
changed the title
josh-willis-arcadis
approved these changes
Jun 25, 2024
| import * as apiActions from '../../actions/api' | ||
| import * as formActions from '../../actions/form' | ||
| import { AppReduxState } from '../../util/state-types' | ||
| import { ComponentContext } from '../../util/contexts' |
|
|
||
| import { blue, getBaseColor } from '../util/colors' | ||
| import { Close } from '@styled-icons/fa-solid' |
There was a problem hiding this comment.
I tried to sort these and literally couldn't get eslint to be happy, so good luck
| import PageTitle from '../util/page-title' | ||
|
|
||
| import React, { RefObject, useContext } from 'react' | ||
| import styled from 'styled-components' |
amy-corson-ibigroup
assigned daniel-heppner-ibigroup and unassigned amy-corson-ibigroup
daniel-heppner-ibigroup
requested changes
Jun 28, 2024
|
|
||
| import { blue, getBaseColor } from '../util/colors' | ||
| import { Close } from '@styled-icons/fa-solid' |
There was a problem hiding this comment.
I tried to sort these and literally couldn't get eslint to be happy, so good luck
| @@ -135,15 +158,13 @@ const AdvancedSettingsPanel = ({ | |||
| <Subheader> | |||
There was a problem hiding this comment.
Let's hide this header if there are no global settings.
Also: Do we need these headers? I don't think they add much value and they take up vertical space.
There was a problem hiding this comment.
I left them invisible for screenreaders since I think they're helpful context, and so some configurations could have access to them! I took them out, let me know what you think? I kinda miss them but I see what you mean.
daniel-heppner-ibigroup
assigned amy-corson-ibigroup and unassigned daniel-heppner-ibigroup
daniel-heppner-ibigroup
approved these changes
Jul 3, 2024
daniel-heppner-ibigroup
assigned amy-corson-ibigroup and unassigned daniel-heppner-ibigroup
amy-corson-ibigroup
merged commit 69d70c6
into
master-trip-form-update
4 of 7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
PR Checklist: