fix(nearby view): add more checks for route deduplication #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Binh Dam <[email protected]> Co-authored-by: Amy Corson <[email protected]>
miles-grant-ibigroup
assigned daniel-heppner-ibigroup and unassigned miles-grant-ibigroup
daniel-heppner-ibigroup
approved these changes
Jun 28, 2024
| (p) => extractHeadsignFromPattern(p.pattern) === currentHeadsign | ||
| ) | ||
| const dupe = acc.findIndex((p) => { | ||
| // TODO: use OTP_generated ids |
There was a problem hiding this comment.
what do we need to do this?
There was a problem hiding this comment.
Futz with the graphql request
There was a problem hiding this comment.
can we do that? Make a ticket for it and assign it to me if you want
daniel-heppner-ibigroup
assigned miles-grant-ibigroup and unassigned daniel-heppner-ibigroup
miles-grant-ibigroup
deleted the
better-nearby-stop-view-route-deduplication
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The route viewer was getting confused by 2 different routes with the same headsign! What a weird edge case.