nearby view new alwaysShowLongName setting
#1237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amy-corson-ibigroup
requested changes
Jun 17, 2024
amy-corson-ibigroup
approved these changes
Jun 25, 2024
josh-willis-arcadis
approved these changes
Jun 27, 2024
| @@ -101,6 +103,11 @@ const PatternRow = ({ | |||
| /> | |||
| </span> | |||
| <span style={{ wordBreak: 'break-word' }} title={pattern.headsign}> | |||
| {alwaysShowLongName && !!pattern.route.longName && ( | |||
There was a problem hiding this comment.
I like the idea of avoiding the crash and having layout issues. Maybe insert a comment here, warning about the potential layout issues to compliment the comment in the config?
There was a problem hiding this comment.
Good idea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
If this is enabled we will show a route long name always, regardless of if there is a duplicate. Only to be enabled in special use cases.