Add Class Names #1236
Merged
Add Class Names #1236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # package.json # yarn.lock
miles-grant-ibigroup
assigned daniel-heppner-ibigroup and unassigned miles-grant-ibigroup
daniel-heppner-ibigroup
requested changes
Aug 8, 2024
| @@ -3,11 +3,12 @@ import { Itinerary, Leg } from '@opentripplanner/types' | |||
| import coreUtils from '@opentripplanner/core-utils' | |||
| import React from 'react' | |||
|
|
|||
| export const getFirstTransitLeg = (itinerary: Itinerary): Leg | undefined => | |||
| itinerary.legs?.find((leg: Leg) => leg?.from?.vertexType === 'TRANSIT') | |||
|
|
|||
| export const getFirstTransitLegStop = ( | |||
There was a problem hiding this comment.
do we even need this function? Could we just get rid of it? Where is it used?
There was a problem hiding this comment.
It's used in the metro itinerary!
There was a problem hiding this comment.
If it wasn't clear this comment is about getFirstTransitLegStop. Literally all it does is return the stop from an itinerary. I don't know that we really need a whole function to do that. There's no logic there
There was a problem hiding this comment.
It's shorter to write out the method than to copy paste that line everywhere!
daniel-heppner-ibigroup
assigned miles-grant-ibigroup and unassigned daniel-heppner-ibigroup
miles-grant-ibigroup
assigned daniel-heppner-ibigroup and unassigned miles-grant-ibigroup
daniel-heppner-ibigroup
assigned miles-grant-ibigroup and unassigned daniel-heppner-ibigroup
daniel-heppner-ibigroup
approved these changes
Aug 9, 2024
amy-corson-ibigroup
approved these changes
Aug 14, 2024
# Conflicts: # __tests__/components/viewers/__snapshots__/nearby-view.js.snap # yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds a bunch of class names all over the place to make post-compile styling easier.
PR Checklist: