Remove old URL params [OTP-1233] #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binh-dam-ibigroup
changed the title
amy-corson-ibigroup
approved these changes
Jun 5, 2024
daniel-heppner-ibigroup
approved these changes
Jun 10, 2024
lib/util/api.ts
Outdated
|
|
||
| /** | ||
| * Drops unused params so they don't show up in URL. | ||
| * TODO: Remove those params from core-utils. |
There was a problem hiding this comment.
Removing these from core-utils would be a big project, because they're still relied on by some other packages which are used in custom uis by some users. I think we should try to remove the dependency on them from OTP-RR instead.
There was a problem hiding this comment.
You are right. The stuff that comes out of getDefaultQuery is not very useful anyway:
bikeSpeed: 3.58
date: "2024-06-11"
departArrive: "NOW"
endTime: "09:00"
from: null
intermediatePlaces: Array []
maxBikeTime: 20
maxEScooterDistance: 4828
maxWalkTime: 15
mode: "WALK,TRANSIT"
numItineraries: 3
otp2: true
routingType: "ITINERARY"
startTime: "07:00"
time: "10:36"
to: null
watts: 250
wheelchair: false
lib/util/api.ts
Outdated
| * Drops unused params so they don't show up in URL. | ||
| * TODO: Remove those params from core-utils. | ||
| */ | ||
| export function removeUnusedQueryParams(params: any): void { |
There was a problem hiding this comment.
make the type Record<string, any>
There was a problem hiding this comment.
Updated in b3f93e4
daniel-heppner-ibigroup
assigned binh-dam-ibigroup and unassigned daniel-heppner-ibigroup
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR remove some (not all) params that are no longer used in OTP searches from the URL.
PR Checklist