Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(apiV2): Don't perform query/UI changes on invalid mode selection #1222

Merged
merged 3 commits into from
May 29, 2024
Merged

fix(apiV2): Don't perform query/UI changes on invalid mode selection #1222

merged 3 commits into from
May 29, 2024

Conversation

binh-dam-ibigroup
Copy link
Collaborator

Description

With this PR, routingQuery exits early before performing any OTP calls if the mode selection is invalid.
If the UI was on search, it remains there. If UI had previous search results, those results continue to be shown.

PR Checklist:

  • Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • Are all languages supported (Internationalization/Localization)?
  • Are appropriate Typescript types implemented?

@binh-dam-ibigroup binh-dam-ibigroup mentioned this pull request May 24, 2024
Merged
3 tasks
amy-corson-ibigroup
amy-corson-ibigroup approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@amy-corson-ibigroup amy-corson-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such a great fix! It would be nice to eventually reset the Ul back to the initial state, so we don't retain any previous successful search results under an invalid search? But I think that can come later

josh-willis-arcadis
josh-willis-arcadis approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@josh-willis-arcadis josh-willis-arcadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@binh-dam-ibigroup binh-dam-ibigroup merged commit 9876fac into dev May 29, 2024
9 checks passed
@binh-dam-ibigroup binh-dam-ibigroup deleted the abort-query-if-invalid-modes branch May 29, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josh-willis-arcadis josh-willis-arcadis josh-willis-arcadis approved these changes

@amy-corson-ibigroup amy-corson-ibigroup amy-corson-ibigroup approved these changes

Assignees

@josh-willis-arcadis josh-willis-arcadis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@binh-dam-ibigroup @amy-corson-ibigroup @josh-willis-arcadis