Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid non-itin-view jumping #1197

Closed
wants to merge 4 commits into from
Closed

Conversation

miles-grant-ibigroup
Copy link
Collaborator

Description:
We used to jump around a lot and it made everyone nauseous. This PR restricts when we run some of these flyTo events.

Please review carefully, this may have created some bugs.

@daniel-heppner-ibigroup
Copy link
Contributor

I see this has fixed some zooming issues in the route viewer, but I'm still seeing a lot of unnecessary zooming in other parts of the app. I think I'd like to see that fixed in this PR as well.

@miles-grant-ibigroup miles-grant-ibigroup added the WIP Work in progress label Apr 24, 2024
@miles-grant-ibigroup miles-grant-ibigroup self-assigned this May 6, 2024
@miles-grant-ibigroup
Copy link
Collaborator Author

I see this has fixed some zooming issues in the route viewer, but I'm still seeing a lot of unnecessary zooming in other parts of the app. I think I'd like to see that fixed in this PR as well.

I'm unable to replicate. All the movement I see is sensible

@miles-grant-ibigroup miles-grant-ibigroup removed their assignment May 23, 2024
@miles-grant-ibigroup miles-grant-ibigroup removed the WIP Work in progress label May 23, 2024
@daniel-heppner-ibigroup
Copy link
Contributor

How to replicate:

  • Plan a trip
  • Move the map
  • Adjust any of the trip form properties, like selecting a mode setting.

Observe how the map zooms unnecessarily back to the planned trip. Not good ux

@miles-grant-ibigroup
Copy link
Collaborator Author

How to replicate:

  • Plan a trip
  • Move the map
  • Adjust any of the trip form properties, like selecting a mode setting.

Observe how the map zooms unnecessarily back to the planned trip. Not good ux

This makes sense though doesn't it? If I'm changing the mode, why would I want to be looking at some random part of the map? I want to be looking at the trip I was planning

@miles-grant-ibigroup
Copy link
Collaborator Author

Ok we have agreed offline to make the jumping overall configurable.

@miles-grant-ibigroup
Copy link
Collaborator Author

#1223 is better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants