Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support route viewer sort in nearby view #1190

Merged
merged 6 commits into from
May 6, 2024

Conversation

miles-grant-ibigroup
Copy link
Collaborator

Description:
There is a route viewer sort algorithm that some will want to use in the nearby view. This is now possible with the new nearbyView. useRouteViewSort

PR Checklist:

  • Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • Are all languages supported (Internationalization/Localization)?
  • Are appropriate Typescript types implemented?

Copy link
Contributor

@daniel-heppner-ibigroup daniel-heppner-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. should it be on by default?

@miles-grant-ibigroup
Copy link
Collaborator Author

LGTM. should it be on by default?

Default is sorted by next arrival. I think it's subjective!

Copy link
Contributor

@amy-corson-ibigroup amy-corson-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@miles-grant-ibigroup miles-grant-ibigroup merged commit 147e870 into dev May 6, 2024
9 checks passed
@miles-grant-ibigroup miles-grant-ibigroup deleted the support-route-viewer-sort-in-nearby-view branch May 6, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants