Support one-time trips #1186
Support one-time trips #1186
Conversation
| <Checkbox checked={isOneTime} onChange={this._handleOneTimeTrip}> | ||
| <FormattedMessage | ||
| id="components.TripBasicsPane.onlyOnDate" | ||
| values={{ date: itinerary.startTime }} | ||
| /> | ||
| </Checkbox> |
There was a problem hiding this comment.
Should this maybe be a radio button instead? I'm thinking of having a big toggle switch between "monitor once" and "monitor regularly" and that way we can hide the calendar view if we have to
…itialize days with itin existen
| export default function pastTripRenderer( | ||
| monitoredTrip: MonitoredTrip | ||
| ): MonitoredTripRenderData { | ||
| const data = baseRenderer(monitoredTrip) as unknown as MonitoredTripRenderData |
There was a problem hiding this comment.
Yikes, what's going on with the type here?
There was a problem hiding this comment.
If I just write as MonitoredTripRenderData, TypeScript doesn't believe me...
There was a problem hiding this comment.
Ah I see, the file it's in isn't typescripted.
| <FormattedMessage id="components.TripBasicsPane.recurringEachWeek" /> | ||
| </Radio> | ||
| {!isOneTime ? ( | ||
| <> |
There was a problem hiding this comment.
Would it be possible to move each side of this ternary into a component so that it's easier to read? I had trouble finding the else part of the ternary, it's a lot of open and close brackets. It's fine if the components are inside this one so there are no props.
There was a problem hiding this comment.
The map in there is also a lot to parse. Feels like a bit too much to tuck inline.
There was a problem hiding this comment.
Oh I just understood that this ternary is being used to just hide this when isOneTime is true. Could it just be !isOneTime && in that case?
There was a problem hiding this comment.
The
mapin there is also a lot to parse. Feels like a bit too much to tuck inline.
There is a redesign of this portion upcoming, so we will address that at that time.
There was a problem hiding this comment.
Could it just be
!isOneTime &&in that case?
Refactored in 655454c.
…hecking existence.
@daniel-heppner-ibigroup Let me know what you think of this fix 655454c. |
daniel-heppner-ibigroup
assigned binh-dam-ibigroup and unassigned daniel-heppner-ibigroup
Description
Works with ibi-group/otp-middleware#224
This PR adds support for saving/monitoring trips that will be taken only once.
Behaviors of note:
<date>" checkbox will uncheck other monitored days. Checking a monitored day will uncheck "Only on<date>".PR Checklist