feat(connected-itinerary-body): make alert collapse configurable #1182
Conversation
example-config.yml
Outdated
| @@ -347,6 +347,8 @@ itinerary: | |||
| renderRouteNamesInBlocks: true | |||
| # Whether the mode icons should be colored as well | |||
| fillModeIcons: true | |||
| # Allow user to collapse alerts in itinerary body | |||
| collapseAlerts: true | |||
There was a problem hiding this comment.
This is misleadingly named. Can we name it allowUserAlertCollapsing?
| @@ -116,6 +117,7 @@ class ConnectedItineraryBody extends Component { | |||
| <ItineraryBodyContainer> | |||
| <StyledItineraryBody | |||
| accessibilityScoreGradationMap={accessibilityScoreGradationMap} | |||
| alwaysCollapseAlerts={allowUserAlertCollapsing} | |||
There was a problem hiding this comment.
| alwaysCollapseAlerts={allowUserAlertCollapsing} | |
| alwaysCollapseAlerts={!allowUserAlertCollapsing} |
Should this be flipped?
There was a problem hiding this comment.
I don't think so, I'm setting allowUserAlertCollapsing to true in the config!
There was a problem hiding this comment.
Unless we want alerts to collapse by default, which might be preferable?
There was a problem hiding this comment.
But as it is right now if allowUserAlertCollapsing is true, then they won't be allowed to collapse them right? Or am I forgetting how the behavior works
There was a problem hiding this comment.
No, alwaysCollapseAlerts needs to be true for the alerts to collapse
binh-dam-ibigroup
assigned miles-grant-ibigroup and amy-corson-ibigroup and unassigned binh-dam-ibigroup and miles-grant-ibigroup
There was a problem hiding this comment.
Approving subject to https://github.com/opentripplanner/otp-react-redux/pull/1182/files#r1543097570.
Co-authored-by: Binh Dam <[email protected]>
Description:
Use
alwaysCollapseAlertsprop in connected itinerary body to configure whether users can collapse alerts.PR Checklist: